From: Florian Müllner <fmuellner@gnome.org>
Date: Fri, 23 Feb 2018 09:27:07 +0000 (+0100)
Subject: messageList: Fix invisible close buttons still working
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~984^2^2~9
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=81dfcb85caeb9e9dd7d3d22c40e037f48844b9b7;p=gnome-shell.git

messageList: Fix invisible close buttons still working

Since commit c4f2bb5f, close buttons are hidden by making them fully
transparent rather than setting their visibility to false to keep
the overall message layout stable. As a result, the buttons now work
even when invisible, which is clearly unexpected - fix this by updating
the reactive property appropriately.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/66
---

diff --git a/js/ui/messageList.js b/js/ui/messageList.js
index 61987191b..aff201ed6 100644
--- a/js/ui/messageList.js
+++ b/js/ui/messageList.js
@@ -502,6 +502,7 @@ var Message = new Lang.Class({
     _sync() {
         let visible = this.actor.hover && this.canClose();
         this._closeButton.opacity = visible ? 255 : 0;
+        this._closeButton.reactive = visible;
     },
 
     _onClicked() {